Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client for the latency1 protocol #35

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Add client for the latency1 protocol #35

merged 3 commits into from
Jan 10, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Jan 10, 2024

Adds a self-contained client for the latency1 protocol.


This change is Reviewable

@coveralls
Copy link

coveralls commented Jan 10, 2024

Pull Request Test Coverage Report for Build 7480441145

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 69.992%

Totals Coverage Status
Change from base Build 7476920368: 0.2%
Covered Lines: 877
Relevant Lines: 1253

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: -- thanks!

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @robertodauria)


cmd/msak-latency/main.go line 130 at r1 (raw file):

		// If a server was provided, use it.
		var err error
		authorizeURL = &url.URL{

I've become a big fan of using flagx.URL for user-specified scheme, servers (maybe path) -- as in minimal-download. What do you think of that approach?

In this case, I might probably add one flag to replace the current server/scheme flags and generate these two urls with specific paths at run time.

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @robertodauria)

@robertodauria robertodauria merged commit ac3c733 into main Jan 10, 2024
7 checks passed
@robertodauria robertodauria deleted the latency branch January 10, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants