Fix issue with partial rebuilds in SCons #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SCons runs the "butler" target, sometimes it erroneously replaced the gen3 butler SQLite file with an empty directory. The exact reasons for this are unclear, but it appears that explicitly tagging the sqlite3 and yaml files as File, and the directories as Dir within SConscript causes the SCons dblite file to be generated properly and to allow for SCons targets to rebuild
weatherhead99
force-pushed
the
tickets/DM-44406
branch
from
a0ca43a
to
ebbe90e
Compare
|
revert the (somewhat unsuccessful) attempts at more complicated fixes, leave just the trivial fix that solves the original rebuild error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SCons runs the "butler" target, sometimes it erroneously replaced the gen3 butler SQLite file with an empty directory.
The exact reasons for this are unclear, but it appears that explicitly tagging the sqlite3 and yaml files as File, and the directories as Dir within SConscript causes the SCons dblite file to be generated properly and to allow for SCons targets to rebuild.
Should fix DM-44406