Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move row data decoding out of state machine #52

Merged
merged 5 commits into from
Jul 6, 2024

Conversation

lovetodream
Copy link
Owner

@lovetodream lovetodream commented Jul 5, 2024

This reduces memory allocations.

@lovetodream lovetodream added the semver-noop No version bump required. label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 97.59450% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (84068c7) to head (8ae7e8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   81.42%   81.63%   +0.20%     
==========================================
  Files         128      130       +2     
  Lines       15051    14865     -186     
==========================================
- Hits        12256    12135     -121     
+ Misses       2795     2730      -65     
Files Coverage Δ
...onnectionStateMachine/ConnectionStateMachine.swift 72.86% <ø> (+2.06%) ⬆️
.../Messages/Coding/OracleBackendMessageDecoder.swift 90.97% <100.00%> (+0.82%) ⬆️
Sources/OracleNIO/Messages/DescribeInfo.swift 95.83% <ø> (-0.03%) ⬇️
...eNIO/Messages/OracleBackendMessage+BitVector.swift 82.35% <100.00%> (ø)
...eNIO/Messages/OracleBackendMessage+Parameter.swift 80.35% <100.00%> (ø)
...rces/OracleNIO/Messages/OracleBackendMessage.swift 70.00% <100.00%> (-0.40%) ⬇️
Sources/OracleNIO/OracleChannelHandler.swift 86.01% <100.00%> (-0.06%) ⬇️
Sources/OracleNIO/Utilities/OracleHexDump.swift 100.00% <100.00%> (ø)
Tests/IntegrationTests/OracleNIOTests.swift 99.81% <100.00%> (+<0.01%) ⬆️
...ctionStateMachine/StatementStateMachineTests.swift 100.00% <100.00%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

@lovetodream lovetodream merged commit c4da4c1 into main Jul 6, 2024
7 checks passed
@lovetodream lovetodream deleted the feature/row-decoding-out-of-state branch July 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-noop No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant