Use IsMaster() in BeginOfRunAction #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use it in constructor as IsMaster() does not return a correct value until that RunAction object is set to a RunManager.
Move GetType() call after having set the file output name. However, this does not fix the empty string returned problem.
|
Accepting PR #55. |
|
Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use IsMaster() in RunAction constructor as IsMaster() does not return a correct value until that RunAction object is set to a RunManager. Reported here.
@stephanlachnit just in case you are using it in the RunAction constructor of other applications :)