💚 Fix artifact name generation in release workflow

lmtani · Dec 18, 2023 · 5274295 · 5274295
1 parent 4094d30
commit 5274295
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -69,9 +69,16 @@ jobs:
       - name: Run test ${{ matrix.tag }}
         run: pytest --git-aware --tag ${{ matrix.tag }} --kwd --basetemp /tmp/ci tests/tasks
 
+      - name: Prepare artifact name
+        id: prepare_artifact_name
+        run: |
+          # This will replace slashes with dashes
+          safe_artifact_name=$(echo "${{ matrix.tag }}" | sed 's:/:-:g')
+          echo "safe_artifact_name=$safe_artifact_name" >> $GITHUB_ENV
+
       - uses: actions/upload-artifact@v4
         with:
-          name: ${{ matrix.tag }}-command
+          name: ${{ env.safe_artifact_name }}-command
           path: /tmp/ci/**/command
 
   release:

diff --git a/tasks/happy/happy.wdl b/tasks/happy/happy.wdl
@@ -40,8 +40,8 @@ task HAPPY {
             ~{query_vcf} \
             ~{"--reference " + fasta} \
             ~{"--threads " + cpus} \
-            ~{"--T " + targets_bed } \
             ~{"--R " + regions_bed } \
+            ~{"--T " + targets_bed } \
             ~{"--false-positives " + false_positives_bed} \
             ~{"--stratification " + stratification_tsv} \
             -o ~{prefix}