feat: ignore error when s3 qeury domains by server may not support

lihsai0 · May 31, 2024 · bdd9945 · bdd9945
1 parent 7954516
commit bdd9945
Showing 1 changed file with 21 additions and 12 deletions.
diff --git a/s3.ts b/s3.ts
@@ -51,6 +51,7 @@ import { HttpClient, RequestStats } from './http-client';
 import { ServiceName } from './kodo-http-client';
 import { RegionRequestOptions } from './region';
 import { generateReqId } from './req_id';
+import {HttpClientResponse} from "urllib";
 
 export const USER_AGENT = `Qiniu-Kodo-S3-Adapter-NodeJS-SDK/${pkg.version} (${os.type()}; ${os.platform()}; ${os.arch()}; )/s3`;
 
@@ -425,18 +426,26 @@ export class S3 extends Kodo {
             bucket,
             type: 'all',
         };
-        const domainResponse = await this.call({
-            method: 'GET',
-            serviceName: ServiceName.Uc,
-            path: 'domain',
-            query: domainQuery,
-            dataType: 'json',
-            s3RegionId,
-
-            // for uplog
-            apiName: 'queryDomain',
-            targetBucket: bucket,
-        });
+
+        let domainResponse: HttpClientResponse<any>;
+        try {
+            domainResponse = await this.call({
+                method: 'GET',
+                serviceName: ServiceName.Uc,
+                path: 'domain',
+                query: domainQuery,
+                dataType: 'json',
+                s3RegionId,
+
+                // for uplog
+                apiName: 'queryDomain',
+                targetBucket: bucket,
+            });
+        } catch (err) {
+            // some server haven't this API. It will cause error.
+            // ignore it with an empty domain list.
+            return [];
+        }
 
         if (!Array.isArray(domainResponse.data)) {
             return [];