Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WIP): Validium pubdata abstraction as enum #78

Conversation

ilitteri
Copy link
Collaborator

@ilitteri ilitteri commented Jan 29, 2024

Description

PoC of Validium mode pubdata abstraction as enum

Changes

  • Add PubdataStorageMode enum with Validium and Rollup variants.
  • Add pubdata_storage_mode field to SenderConfig.
  • Construct or not the pubdata in l1_commit_data depending on which mode the system config was loaded (it is set in eth_sender.toml).
  • Passthrough the variable throughout the codebase wherever it was necessary.

TODOs

  • Add endpoint for retrieving the pubdata.
  • Create a PoC example (binary which calls said endpoint and stores the pubdata initially in a file, could be Celestia later e.g.).

@ilitteri ilitteri marked this pull request as ready for review January 30, 2024 00:57
@ilitteri
Copy link
Collaborator Author

This is not needed

@ilitteri ilitteri closed this Jan 30, 2024
@ilitteri ilitteri deleted the feat_validium_pubdata_abstraction_enum branch February 9, 2024 15:57
Oppen pushed a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants