feat: Eigen Blob ID in L1 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
reviewed
Sep 18, 2024
get_all_blobs/getallblobs.js
Outdated
|
|
||
| async function getTransactions() { | ||
| const latestBlock = await web3.eth.getBlockNumber(); | ||
| const validatorTimelockAddress = "0xeacf0411de906bdd8f2576692486383797d06004"; |
There was a problem hiding this comment.
please parameterize the validatorTimelockAddress and the commitBatchesSharedBridge_functionSelector
juanbono
reviewed
Sep 18, 2024
get_all_blobs/getallblobs.js
Outdated
|
|
||
| getTransactions(); | ||
|
|
||
| //0x4ed3cbf1cf6e8738118f87e5060aee0817c6f18b Chain Admin |
There was a problem hiding this comment.
what is the purpose of these comments?
There was a problem hiding this comment.
They are all the contracts that are called on L1, I think it is nice to leave them somewhere is case we need them in the future. That could go somewhere else tough
juanbono
requested changes
Sep 18, 2024
Done! |
juanbono
reviewed
Sep 18, 2024
get_all_blobs/getallblobs.js
Outdated
| input.slice(10) // Remove the function selector (first 10 characters of the calldata) | ||
| ); | ||
| commitment = hexToUtf8(decodedParams._newBatchesData[0].pubdataCommitments.slice(4)); | ||
| console.log(`Decoded Commitment:`, commitment); |
There was a problem hiding this comment.
please save/print the blobs too.
juanbono
approved these changes
Sep 18, 2024
|
Had some issues running the mentioned procedure
I would recommend applying the second change. |
juan518munoz
approved these changes
Sep 19, 2024
Yeah, typo, its npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds the blob id to be stored on L1 when a batch is committed
It also adds a script for retrieving them directly from L1.
To run it:
This generates a
blob_data.jsonfile, where blobs and commitments are stored.Check
validatorTimelockAddresswhen runningzk initcommitBatchesSharedBridge_functionSelectoris usually0x6edd4f12Why ❔
Checklist
zk fmtandzk lint.