ZK Server Integration #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow any tracer to stop execution
having the result handling in a tracer made the everything very obfuscating
| @@ -59,6 +62,7 @@ pub struct Vm<S: ReadStorage> { | |||
| pub(crate) inner: EraVM, | |||
| pub suspended_at: u16, | |||
| pub gas_for_account_validation: u32, | |||
| pub world: World<S>, | |||
There was a problem hiding this comment.
It might be a good idea to remove the storage and program_cache fields from the Vm since we already have them in world. I know this refactor might be a little bit tricky since it would require changing all the current tests and many other parts of the code. Anyway, I'm leaving this comment in case you'd like to add it here; otherwise, we could open a new issue!
MarcosNicolau
approved these changes
Sep 4, 2024
fkrause98
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR integrates with the zk server, making all test under
zk test i serverpassWhy ❔
Checklist
zk fmtandzk lint.