Kl factory - deposit tests #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkrause98
reviewed
Feb 27, 2024
fkrause98
reviewed
Feb 27, 2024
| @@ -64,7 +64,12 @@ export class TestMaster { | |||
| this.l2Provider.pollingInterval = 5000; | |||
| } | |||
|
|
|||
| this.mainWallet = new zksync.Wallet(suiteWalletPK, this.l2Provider, this.l1Provider); | |||
| // TODO: suiteWalletPK should be the same as the mainWalletPK used in context-owner.ts, otherwise, account won't have funds to operate with. | |||
There was a problem hiding this comment.
Care to explain bit more about this comment?
Do we have an issue for this?
There was a problem hiding this comment.
Upon further inspecting how the testing works, it turns out that the individual wallet used for each test wasn't getting native erc20 funds needed, this is now done inside of distributeL1BaseToken().
fkrause98
reviewed
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
What ❔
Add native/base token
deposittests.Why ❔
Verify correct functionality. To check,
cdintots-integrationdirectory and run the following command:yarn test native-erc20.test.ts(There are two
TODOs that should be addressed before merging)Checklist
zk fmtandzk lint.