Fix creation of ova provider in restricted namespaces. #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
approved these changes
Oct 23, 2023
ahadas
reviewed
Oct 24, 2023
There was a problem hiding this comment.
@bkhizgiy I've rephrased the description of this PR, please also change the commit message
Currently migration to restricted namespaces is working but the provider creation is failing since the ova-server pod doesn't have proper security configuration to run on such namespaces, this fix adds the missing parts. Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Oct 24, 2023
bkhizgiy
added a commit
to bkhizgiy/forklift
that referenced
this pull request
Nov 8, 2023
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
ahadas
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently migration to restricted namespaces is working but the provider creation is failing since the ova-server pod doesn't have proper security configuration to run on such namespaces, this fix adds the missing parts.