Add golangci-lint github action #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
golangci-lint
branch
3 times, most recently
from
e6cc307
to
f461e0c
Compare
ahadas
reviewed
Sep 27, 2023
.github/workflows/golangci-lint.yaml
Outdated
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
@bennyz shouldn't it run on pull_request?
There was a problem hiding this comment.
I think it will run, but yes, it would make sense to remove push here
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
golangci-lint
branch
from
f461e0c
to
b89eef0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.