Switch naming to v2.5.1 #597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LUNs disks are a special case. They do not have a task when migrating and we do not need to update their progress. The disk are pre-made and just being attached. Therefore, we need to skip them. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
In c33a65b, we dropped by mistake the libvirt-domain-xml and vddk-vol-mount mounts from the virt-v2v container when migrating from vSphere (and kept them only when migrating from OVA provider). This broke warm migration from vSphere and decrease the speed of cold-migrations significantly. Thus, adding back the missing mounts. Signed-off-by: Arik Hadas <ahadas@redhat.com>
https://pkg.go.dev/io/ioutil Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
When migrating a LUN disk from ovirt source in warm migration we need to mark the CopyDisk as completed. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Fix the shared disk validation when the attachments array is empty. Fixes kubev2v#442 Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Attempt to properly support remote source by using destination and source clients where appropriate Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Since we now support two flows in the virt-v2v image, it doesn't end with the actual `virt-v2v` command. In that case the pod may end with success although, it didn't. Now the script will exit with an error on the first error occurrence. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
virt-v2v and ovirt-populator podman build is broken without it Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Since adding support for OCP to OCP volumes may not only be PVCs so a nil check has to be made Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
fixing the error in the entrypoint script: line 5: [: missing `]' Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
This patch will bump the ubi9-minimal image and include the fix of the SSL connection to the cold virt-v2v. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
When looking up VMs in plans we need to use the namespace from the Ref, and not rely on splitting the name Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
The format has to always be raw for OpenShift Virtualization Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Skip connection test when updating secret of OVA provider (the URL doesn't change and credentials are not specified) and reduce congnitive complexity of the validateProviderSecret function. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Both methods work the same way but the latter better aligns with how we create other images, like must-gather. Signed-off-by: Arik Hadas <ahadas@redhat.com>
If a volume of a VM changes we need to update the VM's revision to make sure it is revalidated Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
To force revalidation if the volume changed Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
The format of the image is stored as image.diskFormat rather than image.disk_format - change the validation and its tests accordingly. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
We cannot support this currently Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
In order to run on restricted namespaces, the v2v/populator pods need to be set with securityContext.seccompProfile.type that is either RuntimeDefault or Localhost. Thus, we set it in the security context constraints of the service account forklift-controller. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Introduce a new service account for the forklift-populator-controller pod. Currently, it uses the same RBAC as forklift-controller service account. Later on, we will restrict the RBAC to what the populator-controller needs. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
This change will make the target namespaces of the migrations to be restricted. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
... rather than when the hooks are called to avoid "concurrent map read and map write" error. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Until now the target namespace for the migration in the tests were generated by the plan without labeling them. This change will create the target namespace as restricted. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
These changes disable EMS checks when FIPS is enabled by changing configuration files in /etc. The link /etc/pki/tls/fips_local.cnf that points to a configuration file within the FIPS crypto policy is replaced with a regular file, and Options=RHNoEnforceEMSinFIPS is added to the crypto_policy section in /etc/pki/tls/openssl.cnf Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
The namespace may be missing from the network name, in this case we need to use the VM's namespace Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
liranr23
requested review from
ahadas,
eslutsky,
bennyz,
mmartinv,
nyoxi and
mnecas
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.