Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: ocp: consider missing namespace in network name #595

Merged
merged 1 commit into from
Sep 20, 2023
Merged

backport: ocp: consider missing namespace in network name #595

merged 1 commit into from
Sep 20, 2023

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Sep 19, 2023

@bennyz
ocp: consider missing namespace in network name
f6872d5 
The namespace may be missing from the network name, in this case we need
to use the VM's namespace

Also contains:

ocp: extract to function and add unit test

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@bennyz bennyz requested a review from ahadas as a code owner September 19, 2023 12:11
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ahadas ahadas merged commit 70c7ec2 into kubev2v:release-v2.5.1 Sep 20, 2023
5 checks passed
@bennyz bennyz deleted the backport-ocp-network branch September 21, 2023 11:41
@bennyz bennyz restored the backport-ocp-network branch September 28, 2023 10:46
@bennyz bennyz deleted the backport-ocp-network branch September 28, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennyz @ahadas