Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up PVCs when canceling populator flows #590

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Clean up PVCs when canceling populator flows #590

merged 7 commits into from
Oct 23, 2023

Commits on Oct 18, 2023

  1. Clean up PVCs when canceling populator flows 

    This patch will clean up the PVCs (final and prime) associated with VMs
that the migration was cancled for them.

Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
    @liranr23
    liranr23 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    12d417b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. fix error handling in DeletePVCs 

    To return an error when we can't get a prime PVC rather than continue to
the next PVC.

Also refactored the code a bit to reduce cognitive complexity.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ef67399 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. cleanup Migration's Cancel and Archive functions 

    Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    c05456f View commit details
    Browse the repository at this point in the history

  2. Refactor KubeVirt#DeletePVCs 

    Renamed it to DeletePopulatedPVCs and extract the sections that remove
the corresponding prime PVC and the patched PVC to separate functions.

Also rename Migration#cleanUpPopulatorPVCs to delete PopulatorPVCs.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    26993cb View commit details
    Browse the repository at this point in the history

  3. Reduce cognitive complexity in Migration#Cancel 

    Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    6e3e8a7 View commit details
    Browse the repository at this point in the history

  4. Introduce post-vendor.sh 

    This script can be used to clean up vendored code from security issues,
here we remove two unused Dockerfiles that have some security issues.

Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b3e2119 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Clean up as much as possible on migration archive/cancel 

    Signed-off-by: Arik Hadas <ahadas@redhat.com>
    @ahadas
    ahadas committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a168145 View commit details
    Browse the repository at this point in the history