OVA: Change the scanning for ova and ovf files inside the NFS directory #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranr23
reviewed
Sep 6, 2023
bennyz
reviewed
Sep 6, 2023
ahadas
reviewed
Sep 6, 2023
ahadas
reviewed
Sep 7, 2023
bkhizgiy
force-pushed
the
path
branch
2 times, most recently
from
783901d
to
6d148f7
Compare
ahadas
reviewed
Sep 10, 2023
bkhizgiy
force-pushed
the
path
branch
2 times, most recently
from
6be073c
to
a44754b
Compare
liranr23
approved these changes
Sep 11, 2023
ahadas
reviewed
Sep 11, 2023
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
ahadas
approved these changes
Sep 11, 2023
bkhizgiy
added a commit
to bkhizgiy/forklift
that referenced
this pull request
Sep 14, 2023
backport kubev2v#586 Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
ahadas
pushed a commit
that referenced
this pull request
Sep 18, 2023
backport #586 Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current change the files will be scanned as followed:
For OVA files we will search the zero level (the NFS itself) and first level (the share sub folders).
For example giving the nfs share is /nfs these files will be selected:
For extracted OVA files (ovf format) we will search the first level (the NFS sub folders) and second level (the sub folders sub folders).
For example giving the nfs share is /nfs these files will be selected: