Add compatibility ID field for OCP base resource type #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
reviewed
Jul 25, 2023
| Path string `json:"path,omitempty"` | ||
|
|
||
| // forklift ID, for compatability with providers using ID instead of UID | ||
| ID string `json:"id"` |
There was a problem hiding this comment.
Suggested change
| ID string `json:"id"` | |
| ID string `json:"id,omitempty"` |
Signed-off-by: yaacov <yzamir@redhat.com>
yaacov
force-pushed
the
add-base-id-field-for-ocp
branch
from
3aa535a
to
243e1aa
Compare
bennyz
approved these changes
Jul 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
bennyz
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compatibility ID field for OCP base resource type
Why this is needed:
Users of forklift API (for example the UI) expect an "id" json field and not a "uid" field.