Adding OVA migration flow #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ahadas
reviewed
Jul 25, 2023
liranr23
reviewed
Jul 25, 2023
ahadas
reviewed
Jul 26, 2023
ahadas
reviewed
Jul 26, 2023
ahadas
reviewed
Jul 26, 2023
bkhizgiy
force-pushed
the
ova_migration
branch
2 times, most recently
from
c048dc9
to
be2a49f
Compare
liranr23
approved these changes
Jul 26, 2023
ahadas
reviewed
Jul 26, 2023
There was a problem hiding this comment.
@bkhizgiy the changes look good now but please take a look at the code-smell issues that are reported for this PR, specifically the "Define a constant instead of duplicating this literal" ones (and maybe other "easy catches") - the more things (that we're not going to backport) we solve now, the better as future backports would be easier
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
ahadas
approved these changes
Jul 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding OVA flow for migration