openstack-populator: support new authentication types #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartinv
force-pushed
the
openstack-populator-support-new-authentication-types
branch
from
155340d
to
fa707ec
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 28.55% 28.55% -0.01%
==========================================
Files 48 48
Lines 9939 9940 +1
==========================================
Hits 2838 2838
- Misses 6878 6879 +1
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahadas
approved these changes
Jun 30, 2023
bennyz
approved these changes
Jun 30, 2023
mmartinv
force-pushed
the
openstack-populator-support-new-authentication-types
branch
from
fa707ec
to
ff8e079
Compare
bennyz
reviewed
Jun 30, 2023
Support the new authentication types introduced in kubev2v#309 Signed-off-by: Miguel Martín <mmartinv@redhat.com>
mmartinv
force-pushed
the
openstack-populator-support-new-authentication-types
branch
from
ff8e079
to
111368c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bennyz
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the new authentication types introduced in #309
Signed-off-by: Miguel Martín mmartinv@redhat.com