Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary renaming of imported VMs #404

Merged
merged 2 commits into from
Jun 25, 2023

Conversation

liranr23
Copy link
Member

When updating the plan some data is not loaded from the server, like status. We previously fixed this issue partially in commits c286c78 and c97a2b8.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (73a6b92) 28.53% compared to head (4633fcb) 28.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   28.53%   28.53%           
=======================================
  Files          47       47           
  Lines        9936     9934    -2     
=======================================
  Hits         2835     2835           
+ Misses       6878     6876    -2     
  Partials      223      223           
Flag Coverage Δ
unittests 28.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

liranr23 and others added 2 commits June 25, 2023 18:24
When updating the plan some data is not loaded from the server, like
status. We previously fixed this issue partially in commits c286c78
and c97a2b8.

Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

@ahadas ahadas changed the title Fix the plan status Prevent unnecessary rename of import VMs Jun 25, 2023
@ahadas ahadas changed the title Prevent unnecessary rename of import VMs Prevent unnecessary rename of imported VMs Jun 25, 2023
@ahadas ahadas changed the title Prevent unnecessary rename of imported VMs Prevent unnecessary renaming of imported VMs Jun 25, 2023
@ahadas ahadas merged commit 71d5b9b into kubev2v:main Jun 25, 2023
8 of 9 checks passed
@liranr23 liranr23 deleted the fix_plan_status branch June 19, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants