openstack: update validation rules

[mmartinv]

Signed-off-by: Miguel Martín mmartinv@redhat.com

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (84a1235) 28.53% compared to head (77a27e2) 28.53%.

❗ Current head 77a27e2 differs from pull request most recent head 7a91a00. Consider uploading reports for the commit 7a91a00 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   28.53%   28.53%           
=======================================
  Files          47       47           
  Lines        9936     9936           
=======================================
  Hits         2835     2835           
  Misses       6878     6878           
  Partials      223      223           

Flag	Coverage Δ
unittests	28.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ahadas]

a minor comment about wording inside, and also for consistency we need to change bios_boot_menu.rego and cpu_shares.rego for ovirt as well

[mmartinv]

@ahadas maybe we should also review the rest of the rules with Information category, change them to Warning and add more context explaining what will happen if the VM is migrated.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ahadas]

@ahadas maybe we should also review the rest of the rules with Information category, change them to Warning and add more context explaining what will happen if the VM is migrated.

yeah but that can be done in a separate PR(s)