Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile deploy/undeploy targets #398

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

mmartinv
Copy link
Contributor

Signed-off-by: Miguel Martín mmartinv@redhat.com

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3533ffb) 0.00% compared to head (a773648) 0.00%.

❗ Current head a773648 differs from pull request most recent head 60ee0e7. Consider uploading reports for the commit 60ee0e7 to get more accurate results

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #398   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmartinv mmartinv force-pushed the makefile-deploy-undeploy-targets branch from 15d32b5 to 393ff59 Compare June 20, 2023 07:35
@mmartinv mmartinv marked this pull request as ready for review June 20, 2023 07:37
@mmartinv mmartinv force-pushed the makefile-deploy-undeploy-targets branch from 393ff59 to a339c19 Compare June 20, 2023 08:36
Makefile Outdated Show resolved Hide resolved
hack/deploy/forklift/resources/forkliftcontroller.yaml Outdated Show resolved Hide resolved
hack/deploy/operator/resources/namespace.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mmartinv mmartinv force-pushed the makefile-deploy-undeploy-targets branch from a339c19 to 9b69696 Compare June 26, 2023 09:15
@mmartinv mmartinv requested a review from nyoxi as a code owner June 26, 2023 09:15
@mmartinv mmartinv force-pushed the makefile-deploy-undeploy-targets branch from b083b69 to 0b3272a Compare June 27, 2023 15:09
@ahadas ahadas force-pushed the makefile-deploy-undeploy-targets branch from 0b3272a to 6a194de Compare June 29, 2023 10:32
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, few more minor comments inside and we're ready to go with this

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/deploy/crc.sh Outdated Show resolved Hide resolved
hack/deploy/kind.sh Outdated Show resolved Hide resolved
hack/deploy/minikube.sh Outdated Show resolved Hide resolved
@mmartinv mmartinv force-pushed the makefile-deploy-undeploy-targets branch 3 times, most recently from 318791b to 360a02a Compare July 11, 2023 06:30
Makefile Outdated Show resolved Hide resolved
hack/installation/env.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
mmartinv added a commit to mmartinv/forkliftci that referenced this pull request Jul 14, 2023
We need to rename it because of kubev2v/forklift#398

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
@mmartinv mmartinv force-pushed the makefile-deploy-undeploy-targets branch 2 times, most recently from fcf85e1 to a773648 Compare July 14, 2023 09:01
Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Add targets to deploy/undeploy forklift to different
environments. Currently supported:

* OpenShift/OKD
* CRC
* Minikube
* Kind

Targets to install CRC, Minikube and Kind are also provided

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
@ahadas ahadas force-pushed the makefile-deploy-undeploy-targets branch from a773648 to ae4a05c Compare July 16, 2023 12:12
Signed-off-by: Arik Hadas <ahadas@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ahadas ahadas self-requested a review July 16, 2023 22:07
@ahadas ahadas merged commit fadd508 into kubev2v:main Jul 16, 2023
7 checks passed
ahadas pushed a commit to kubev2v/forkliftci that referenced this pull request Jul 17, 2023
We need to rename it because of kubev2v/forklift#398

Signed-off-by: Miguel Martín <mmartinv@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants