Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images to the select provider in create provider form #536

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add images to the select provider in create provider form #536

merged 1 commit into from
Jul 11, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 11, 2023 •
edited
Loading

Issue:
select provider list is lacking provider icons

Fix:
add icons

Screenshot:
Before:
screenshot-localhost_9000-2023 07 11-11_45_57

After:
screenshot-localhost_9000-2023 07 11-11_28_00

Issue #528

@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jul 11, 2023
@yaacov yaacov added this to the 2.5.0 milestone Jul 11, 2023
@yaacov yaacov linked an issue Jul 11, 2023 that may be closed by this pull request
show provider icons when choosing a provider #528
Closed
@yaacov
Add images to the select provider in create provider form
1800ef0 
Signed-off-by: yaacov <yzamir@redhat.com>
@yaacov yaacov force-pushed the add-images-to-select-provider-type branch from 1bb3592 to 1800ef0 Compare July 11, 2023 08:44
@yaacov yaacov merged commit e1e7fd8 into kubev2v:main Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

show provider icons when choosing a provider
1 participant
@yaacov