Fix UI refresh issues for providers secret data and for migration plan VMs list #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n VMs list Fix UI refresh issues that are a result of a wrong react query fetching/caching options. 1. For the providers secret data sync issue, apply the invalidateQueries option for the 'secret' query. 2. For the migration plan VMs list sync issue, avoid the 'keepPreviousData' option and apply the invalidateQueries option for the 'inventory-tree' query. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
yaacov
approved these changes
Jun 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
cc:// @ahadas |
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #369
Fix UI refresh issues that are a result of a wrong react query fetching/caching options.
For the providers secret data sync issue, apply the invalidateQueries option for the 'secret' query.
For the migration plan VMs list sync issue, avoid the 'keepPreviousData' option and apply the invalidateQueries option for the 'inventory-tree' query.
Fix result:
When editing an existing provider's secret data, the data is updated successfully and immediately in the UI, without the need to hard refresh.
When adding a new VM(s) to the source provider, while the migration plan UI wizard is already opened , the new VM is added successfully in the UI, without the need to re-open the migration plan wizard.