🐞 when migration task isn't completed but the migration is successful, mark task as successful #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgratch
changed the title
yaacov
reviewed
Sep 16, 2024
packages/forklift-console-plugin/src/modules/Plans/views/details/utils/hasPipelineCompleted.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Sep 16, 2024
packages/forklift-console-plugin/src/modules/Plans/views/details/utils/hasPipelineCompleted.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Sep 16, 2024
packages/forklift-console-plugin/src/modules/Plans/views/details/utils/hasPipelineCompleted.tsx
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
mark-migration-tasks-as-completed-if-pipeline-is
branch
from
4b93cc1
to
fa35e31
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1324 +/- ##
==========================================
- Coverage 36.81% 36.50% -0.31%
==========================================
Files 158 159 +1
Lines 2548 2586 +38
Branches 599 603 +4
==========================================
+ Hits 938 944 +6
- Misses 1428 1460 +32
Partials 182 182 ☔ View full report in Codecov by Sentry. |
…mark task as successful, Reference: kubev2v#1305 In case a migraiton task is not marked as finished (i.e. task.phase is undefined), but its pipeline step is marked as completed succesfully then mark the task as completed succesfully as well. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
sgratch
force-pushed
the
mark-migration-tasks-as-completed-if-pipeline-is
branch
from
fa35e31
to
c774a55
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1305
In case a VM migration task is not marked as finished (i.e. task.phase is undefined), but its pipeline step is marked as completed successfully then mark the task in UI as completed successfully as well.
This will solve cases as mentioned in #1305 in which the
DiskTransferV2vorDiskTransfertasks aren't completed although the migration is successful.This fix was done for all migration VM types (not necessarily limited for vSphere or OVA VMs).
Before
After
Note that the Task modal popup will still show the real info and will reflect that the task was not really finished:
