Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Rephrase migration phase label for failed VMs under uncompleted Plan #1318

Merged
merged 1 commit into from
Sep 8, 2024
Merged

🐞 Rephrase migration phase label for failed VMs under uncompleted Plan #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@
"Skip certificate validation": "Skip certificate validation",
"Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.",
"Snapshot polling interval (seconds)": "Snapshot polling interval (seconds)",
"Some VMs Failed": "Some VMs Failed",
"Something is wrong, the data was not loaded due to an error, please try to reload the page.": "Something is wrong, the data was not loaded due to an error, please try to reload the page.",
"Something is wrong, the secret was not loaded, please try to reload the page.": "Something is wrong, the secret was not loaded, please try to reload the page.",
"source": "source",
Expand Down Expand Up @@ -527,7 +528,6 @@
"Virtual machines": "Virtual machines",
"Virtual Machines": "Virtual Machines",
"Virtual machines:": "Virtual machines:",
"VM Failed": "VM Failed",
"VM(s) with more than one interface mapped to Pod Networking were detected.": "VM(s) with more than one interface mapped to Pod Networking were detected.",
"VM(s) with multiple NICs on the same network were detected.": "VM(s) with multiple NICs on the same network were detected.",
"VM(s) with NICs that are not linked with a NIC profile were detected.": "VM(s) with NICs that are not linked with a NIC profile were detected.",
Expand Down
4 changes: 2 additions & 2 deletions packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ const phaseLabels: Record<PlanPhase, string> = {
Error: 'Error',
// t('Warning')
Warning: 'Warning',
// t('VM Failed')
vmError: 'VM Failed',
// t('Some VMs Failed')
vmError: 'Some VMs Failed',
// t('Unknown')
Unknown: 'Unknown',
};