Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Remove unused settings must gather cleanup #1227

Merged
merged 1 commit into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@
"Edit Maximum concurrent VM migrations": "Edit Maximum concurrent VM migrations",
"Edit migration plan target namespace": "Edit migration plan target namespace",
"Edit migration plan transfer network": "Edit migration plan transfer network",
"Edit Must gather cleanup after (hours)": "Edit Must gather cleanup after (hours)",
"Edit NetworkMap": "Edit NetworkMap",
"Edit Plan": "Edit Plan",
"Edit plan name": "Edit plan name",
Expand Down Expand Up @@ -250,7 +249,6 @@
"MTU": "MTU",
"Multiple NICs mapped to Pod Networking ": "Multiple NICs mapped to Pod Networking ",
"Multiple NICs on the same network": "Multiple NICs on the same network",
"Must gather cleanup after (hours)": "Must gather cleanup after (hours)",
"Name": "Name",
"Name is primarily intended for creation idempotence and configuration definition. Cannot be updated.": "Name is primarily intended for creation idempotence and configuration definition. Cannot be updated.",
"Name is required and must be a unique within a namespace and valid Kubernetes name.": "Name is required and must be a unique within a namespace and valid Kubernetes name.",
Expand Down Expand Up @@ -347,7 +345,6 @@
"Please enter the interval in seconds for snapshot pooling, if empty default value will be used.": "Please enter the interval in seconds for snapshot pooling, if empty default value will be used.",
"Please enter the limit for CPU usage by the controller in milliCPU, if empty default value will be used.": "Please enter the limit for CPU usage by the controller in milliCPU, if empty default value will be used.",
"Please enter the limit for memory usage by the controller in Mi, if empty default value will be used.": "Please enter the limit for memory usage by the controller in Mi, if empty default value will be used.",
"Please enter the maximum age in hours for must gather cleanup, if empty default value will be used.": "Please enter the maximum age in hours for must gather cleanup, if empty default value will be used.",
"Please enter the maximum number of concurrent VM migrations, if empty default value will be used.": "Please enter the maximum number of concurrent VM migrations, if empty default value will be used.",
"Pod": "Pod",
"Pod network": "Pod network",
Expand Down Expand Up @@ -429,7 +426,6 @@
"source": "source",
"Source Only": "Source Only",
"Source provider": "Source provider",
"Specifies the duration for retaining 'must gather' reports before they are automatically deleted. The default value is -1, which implies automatic cleanup is disabled.": "Specifies the duration for retaining 'must gather' reports before they are automatically deleted. The default value is -1, which implies automatic cleanup is disabled.",
"Specify a list of passphrases for the Linux Unified Key Setup (LUKS)-encrypted devices for the VMs that you want to migrate.": "Specify a list of passphrases for the Linux Unified Key Setup (LUKS)-encrypted devices for the VMs that you want to migrate.",
"Specify the type of source provider. Allowed values are ova, ovirt, vsphere,\n openshift, and openstack. This label is needed to verify the credentials are correct when the remote system is accessible and, for RHV, to retrieve the Manager CA certificate when\n a third-party certificate is specified.": "Specify the type of source provider. Allowed values are ova, ovirt, vsphere,\n openshift, and openstack. This label is needed to verify the credentials are correct when the remote system is accessible and, for RHV, to retrieve the Manager CA certificate when\n a third-party certificate is specified.",
"Staging": "Staging",
Expand Down Expand Up @@ -468,7 +464,6 @@
"The limit for CPU usage by the controller, specified in milliCPU. Default value is 500m.": "The limit for CPU usage by the controller, specified in milliCPU. Default value is 500m.",
"The limit for memory usage by the controller, specified in Megabytes (Mi). Default value is 800Mi.": "The limit for memory usage by the controller, specified in Megabytes (Mi). Default value is 800Mi.",
"The Manager CA certificate unless it was replaced by a third-party certificate, in which case, enter the Manager Apache CA certificate.": "The Manager CA certificate unless it was replaced by a third-party certificate, in which case, enter the Manager Apache CA certificate.",
"The maximum age in hours for must gather cleanup. Default value is -1, which implies never.": "The maximum age in hours for must gather cleanup. Default value is -1, which implies never.",
"The password for the ESXi host admin": "The password for the ESXi host admin",
"The plan is not ready - ": "The plan is not ready - ",
"The provider is not ready - ": "The provider is not ready - ",
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// @index(['./*', /style/g], f => `export * from '${f.path}';`)
export * from './EditCleanupMaxAgeModal';
export * from './EditControllerCPULimitModal';
export * from './EditControllerMemoryLimitModal';
export * from './EditMaxVMInFlightModal';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { FC } from 'react';
import {
EditCleanupMaxAgeModal,
EditControllerCPULimitModal,
EditControllerMemoryLimitModal,
EditMaxVMInFlightModal,
Expand All @@ -24,11 +23,6 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
const { t } = useForkliftTranslation();
const { showModal } = useModal();

const mustGatherAPICleanupMaxAge =
obj?.spec?.['must_gather_api_cleanup_max_age'] === -1
? 'Disabled'
: obj?.spec?.['must_gather_api_cleanup_max_age'];

return (
<Card>
<CardTitle className="forklift-title">{t('Settings')}</CardTitle>
Expand Down Expand Up @@ -60,30 +54,6 @@ const SettingsCard_: FC<SettingsCardProps> = ({ obj }) => {
onEdit={() => showModal(<EditMaxVMInFlightModal resource={obj} />)}
/>

<DetailsItem
title={'Must gather cleanup after (hours)'}
showHelpIconNextToTitle={true}
content={
mustGatherAPICleanupMaxAge && mustGatherAPICleanupMaxAge !== '-1' ? (
mustGatherAPICleanupMaxAge
) : (
<span className="text-muted">{'Disabled'}</span>
)
}
moreInfoLink={
'https://access.redhat.com/documentation/en-us/migration_toolkit_for_virtualization/2.6/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#advanced-migration-options'
}
helpContent={
<Text>
{t(
"Specifies the duration for retaining 'must gather' reports before they are automatically deleted. The default value is -1, which implies automatic cleanup is disabled.",
)}
</Text>
}
crumbs={['spec', 'must_gather_api_cleanup_max_age']}
onEdit={() => showModal(<EditCleanupMaxAgeModal resource={obj} />)}
/>

<DetailsItem
title={'Controller main container CPU limit'}
showHelpIconNextToTitle={true}
Expand Down