Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Error when vddk init image is empty #1210

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 13, 2024

Ref: #1206

Issue:
When creating and editing a vmware provider it's easy to leave the vddk container image empty

Fix:
Add a checkbox for users to confirm they want an empty image

  • Error field and form if image is empty, edit and create provider
  • Allow to override empty image error using a checkbox, edit and create provider
  • In details page, make empty image a warning

Screenshots:
create-vddk-image-empty
create-vddk-image
details-vddk-image-empty
edit-vddk-image-empty
edit-vddk-image

Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jun 13, 2024
@yaacov yaacov added this to the 2.7.0 milestone Jun 13, 2024
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
25.3% Duplication on New Code

See analysis details on SonarCloud

@yaacov yaacov merged commit 8f04f2e into kubev2v:main Jun 13, 2024
8 checks passed
@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jun 20, 2024
@jsakil14
Copy link

@yaacov I am having trouble with invalidvddkimage , is there any specific file I should be using? I am running forklift version 2.7.0 - (target) kubevirt cluster 1.0 / k8s version 1.25.10 - vsphere 7.x (source) ---
can I use images from kubevirt quay.io repo? if so , vddk-init or vddk-test...If from broadcom which version specifically - I am lost , raised issue kubev2v/forklift#971

Do i have to clear all old plans if I am changing provider vddk ? or what is the clean way to reinstall provider with vddk changes or understand errors from controller logs better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants