Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Warn on manual hooks in plan #1200

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 6, 2024

Ref: #1199

Issue:
A user may create a valid plan with unsupported hooks settings.

Fix:
Warn users before editing hooks in the UI, that the current settings is not supported by the UI, and the current unsupported settings will be overwritten and lost if the user edit the hooks using the UI.

Screenshot:
hooks-warning

Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jun 6, 2024
@yaacov yaacov added this to the 2.7.0 milestone Jun 6, 2024
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaacov yaacov merged commit baf3888 into kubev2v:main Jun 6, 2024
8 checks passed
@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant