Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand docs for ProvisioningRequest #7297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

expand docs for ProvisioningRequest #7297

wants to merge 1 commit into from
+64 −2

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Sep 20, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  • instructions were missing the crd
  • was unclear who needs to api flag
  • had no examples how the request actually works

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

cc @yaroslava-serdiuk

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grosser
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @grosser. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2024
Shubham82
Shubham82 suggested changes Sep 20, 2024
View reviewed changes
cluster-autoscaler/FAQ.md
@@ -609,6 +610,8 @@ subjects:
namespace: kube-system
```

5. Deploy the [ProvisioningRequest CRD](apis/config/crd/autoscaling.x-k8s.io_provisioningrequests.yaml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Deploy the [ProvisioningRequest CRD](apis/config/crd/autoscaling.x-k8s.io_provisioningrequests.yaml)
5. Deploy the [ProvisioningRequest CRD](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/apis/config/crd/autoscaling.x-k8s.io_provisioningrequests.yaml)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grosser, PR looks good to me, Just one update link the full URL to it.

@Shubham82
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubham82 Shubham82 Shubham82 requested changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees
No one assigned
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grosser @k8s-ci-robot @Shubham82