🌱 e2e-tests: fix/cleanup and add test to validate webhooks outside of the manager namespace #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
add-test-webhook-outside
branch
from
9d8180e
to
8878dd8
Compare
k8s-ci-robot
added
size/L
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
add-test-webhook-outside
branch
from
8878dd8
to
3eafa9a
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
add-test-webhook-outside
branch
from
3eafa9a
to
c49dbc1
Compare
…he manager namespace - remove the steps to check webhook networkpolicy failures since those are not accurated. - cleanup the tests - add test to ensure that weebhoks are working well in namespaces which are not those where the webhook-service and manager are applied
camilamacedo86
force-pushed
the
add-test-webhook-outside
branch
from
c49dbc1
to
29192d8
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-kubebuilder-e2e-k8s-1-29-2 |
|
I will move with this one because it is just a silly/small fix/cleanup and addition |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4149