👻 Tasking find refs #673
Merged
👻 Tasking find refs #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odel. Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam
reviewed
Jun 21, 2024
task/manager.go
Outdated
| } | ||
| kind, found := m.cluster.tasks[task.Kind] | ||
| if !found { | ||
| err = &ExtensionNotFound{Name: task.Kind} |
mansam
reviewed
Jun 21, 2024
importer/manager.go
Outdated
| @@ -356,19 +356,12 @@ func (m *Manager) createApplication(imp *model.Import) (ok bool) { | |||
|
|
|||
| func (m *Manager) discover(application *model.Application) (err error) { | |||
| for _, kind := range Settings.Hub.Discovery.Tasks { | |||
| t := api.Task{} | |||
| t := &tasking.Task{} | |||
There was a problem hiding this comment.
Underlying model.Task needs to be initialized
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
force-pushed
the
tasking-findRefs
branch
2 times, most recently
from
b0a265f
to
c9bdc1c
Compare
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam
reviewed
Jun 26, 2024
| @@ -336,7 +327,7 @@ func (h TaskHandler) Delete(ctx *gin.Context) { | |||
| // @description Update a task. | |||
| // @tags tasks | |||
| // @accept json | |||
| // @success 202 | |||
There was a problem hiding this comment.
This and patch probably should go back to being a 204
mansam
approved these changes
Jun 26, 2024
|
Looks like the tests might need to be adjusted to deal with delete/cancel being fully aync. |
Signed-off-by: Jeff Ortel <jortel@redhat.com>
|
E2E Test checkout is currently broken by my recent PR fixing diverged branches failures konveyor/go-konveyor-tests#132 The error looks to be caused by just using main branch API tests in E2E test suite, instead of updated tests in this PR. I will update CI scripts, meanwhile in this case, feel free go ahead with merging. |
aufi
approved these changes
Jun 27, 2024
shawn-hurley
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 9b4cc38.
dymurray
pushed a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.