Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIER3: binary analysis #81

Merged
merged 4 commits into from
Jan 23, 2024
Merged

TIER3: binary analysis #81

merged 4 commits into from
Jan 23, 2024

Conversation

mguetta1
Copy link
Collaborator

@mguetta1 mguetta1 commented Jan 17, 2024

Adding binary analysis test case for tackle-testapp, private repo
GITHUB_USER and GITHUB_TOKEN can be provided as configuration variables (in config/config.json) or as environment vars

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1 mguetta1 marked this pull request as ready for review January 17, 2024 13:28
@aufi
Copy link
Member

aufi commented Jan 17, 2024

@mguetta1 Please take as a template test case TestApp with deps https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_tackle_testapp_public_deps.go (this one is part of TIER0)

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@aufi
Copy link
Member

aufi commented Jan 19, 2024

Thanks for update Maayan! PR looks good, Just to understand better what the Binary mode means. I can see Binary field on analysis and application (that should be checkout from SVN) in this PR. Just to be sure, isn't it needed to upload the application binary file to application's bucket to use it for analysis?

@sshveta
Copy link
Collaborator

sshveta commented Jan 19, 2024

Thanks for update Maayan! PR looks good, Just to understand better what the Binary mode means. I can see Binary field on analysis and application (that should be checkout from SVN) in this PR. Just to be sure, isn't it needed to upload the application binary file to application's bucket to use it for analysis?

There are two modes of analysis @aufi .
In binary analysis we provide source code which contains an embedded binary in the repo.
Second is "Upload Binary" where we upload a ear/jar/war/zip file for analysis .

This PR covers the first option . Binary analysis on source repo.

@mguetta1 mguetta1 merged commit e343f10 into konveyor:main Jan 23, 2024
4 of 5 checks passed
mguetta1 added a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1 added a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1 added a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1 mguetta1 deleted the tier3-analysis branch January 31, 2024 11:28
mguetta1 added a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants