Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR tester jenkinsfile #77

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Conversation

msajidmansoori12
Copy link
Collaborator

Add jenkins pipeline to test PRs again tier3 tests (JIRA tests) which need some sensitive data.

@msajidmansoori12 msajidmansoori12 force-pushed the add-pr-tester branch 2 times, most recently from c264484 to 48835d9 Compare December 18, 2023 05:44
PR_TESTER.jenkinsfile Outdated Show resolved Hide resolved
@msajidmansoori12 msajidmansoori12 force-pushed the add-pr-tester branch 2 times, most recently from fc2f63c to 71b003b Compare December 18, 2023 07:04
Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: M Sajid Mansoori <mmansoor@redhat.com>
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with Jenkins, but looks good.

environment{
HUB_USERNAME="admin"
PATH="$PATH:/usr/local/go/bin"
HUB_PASSWORD="Passw0rd!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is some example password, not working on some running system.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the default password and it is used with keycloak_sso_req_passwd_update: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is the right thing to store even default passwords in public git repo, but just my $0.02.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aufi Thanks for your input , I don't mind removing these from here. I'll make the changes :)

Signed-off-by: M Sajid Mansoori <mmansoor@redhat.com>
@msajidmansoori12
Copy link
Collaborator Author

@aufi @mguetta1 i've made the final changes , can you please merge this PR.

@mguetta1 mguetta1 merged commit 96ea98e into konveyor:main Dec 24, 2023
4 of 5 checks passed
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 11, 2024
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 11, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants