-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR tester jenkinsfile #77
Conversation
c264484
to
48835d9
Compare
fc2f63c
to
71b003b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: M Sajid Mansoori <mmansoor@redhat.com>
71b003b
to
e0f5499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with Jenkins, but looks good.
PR_TESTER.jenkinsfile
Outdated
environment{ | ||
HUB_USERNAME="admin" | ||
PATH="$PATH:/usr/local/go/bin" | ||
HUB_PASSWORD="Passw0rd!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is some example password, not working on some running system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the default password and it is used with keycloak_sso_req_passwd_update: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is the right thing to store even default passwords in public git repo, but just my $0.02.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aufi Thanks for your input , I don't mind removing these from here. I'll make the changes :)
Signed-off-by: M Sajid Mansoori <mmansoor@redhat.com>
4ea01fa
to
b3040b1
Compare
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Add jenkins pipeline to test PRs again tier3 tests (JIRA tests) which need some sensitive data.