🐛 adding test case to make sure that the scopes work #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
bugfix/adding-testcase-for-scopes
branch
from
a52a90f
to
0f5dbc5
Compare
aufi
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks for the PR Shawn!
Looks good to me, happy to see it merged once konveyor/tackle2-addon-analyzer#69 is in and tier0 test gets green.
shawn-hurley
force-pushed
the
bugfix/adding-testcase-for-scopes
branch
3 times, most recently
from
e085151
to
5f9b7d0
Compare
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
bugfix/adding-testcase-for-scopes
branch
from
5f9b7d0
to
3e88ff0
Compare
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Jan 11, 2024
Signed-off-by: Shawn Hurley <shawn@hurley.page>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Jan 11, 2024
Signed-off-by: Shawn Hurley <shawn@hurley.page> Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the test with scopes