Update README and configuration file #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetta1
changed the title
mguetta1
changed the title
aufi
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks for the PR Maayan! I'd like ask for more detailed information what applications need what permissions on the token.
Like https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_tackle_testapp_private_binary.go needs token to access XY repository with read access, etc.
Probably don't have to be in readme, comments on the tests case might be enough, just to help find out what token is needed to reproduce the test execution. cc @pranavgaikwad
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1
force-pushed
the
readme
branch
3 times, most recently
from
aab5566
to
35fde13
Compare
sshveta
reviewed
May 1, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
aufi
approved these changes
May 2, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1
added
the
cherry-pick/release-0.3
github-actions bot
pushed a commit
that referenced
this pull request
May 2, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
mguetta1
added a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.