-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix private binary app analysis tier3 #114
Conversation
Updating expected incidents files prefix and adding more readable diff for issues and incident lists. This should fix tier3 test. Signed-off-by: Marek Aufart <maufart@redhat.com>
@pranavgaikwad @mguetta1 There is one incident less (than expected) for local-storage-00001, is it some known analyzer/test update?
|
It is with https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_tackle_testapp_private_binary.go#L47-L56 test expectation, the first incident in the file on line 8 is found, but not the other one that should be on line 37 (note, this application looks to be slightly different to tackle-testapp from github https://github.com/konveyor/tackle-testapp-public or https://github.com/konveyor/tackle-testapp) |
Signed-off-by: Marek Aufart <maufart@redhat.com>
Confirmed with @pranavgaikwad that the incident on line 37 is not recognized intentionaly after analyzer/rules change. Analysis in tier3 test now works for me.
|
TIER2 is expected to fail. |
Signed-off-by: Marek Aufart <maufart@redhat.com>
@pranavgaikwad Good point, updated, example:
|
Hi @aufi |
Updating expected incidents files prefix and adding more readable diff for issues and incident lists.
This should fix tier3 test.