-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: PCA and UMAP OutlierDetection docstring examples #654
Conversation
… little mistake I made in outlier_remover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering, how did you come up with these array values?
Wouldn't make sense to have some randomly generated arrays (with fixed seed) and then tinker around some value to make them outliers? Point is: currently I cannot spot outliers just by looking at the arrays and everything seems a bit magical.
On the Github action failing: Getting a sense that macos-latest runner is on macos 14, and it is breaking most of github actions.
I can't deep dive today, but will try in the coming week.
Anyway, certainly unrelated from the docstring changes
Yep the doc page is using iris dataset, which I would not expect to have any particular outlier. @koaning thoughts on this? In my opinion, it could be worth it to change dataset in the user guide as well. It seems a bit confusing |
Sure, I'll do it the way it's done in the test suite. |
Hey Francesco I'm back at it. I was having some thoughts about the examples for PCA and UMAPs, what bugs me is that if I use the obvious example which is a 10-d array, how can I show the resulting outliers? Should I print the 10d output? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it ✨
Docs
Added usage examples to:
decomposition.umap_reconstruction.UMAPOutlierDetection
decomposition.pca_reconstruction.PCAOutlierDetection
Fixes #652 and #653
Type of change