Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BXMSPROD-2081: Remove PLANNING capability (#1547) #1599

Closed
wants to merge 1 commit into from
Closed

BXMSPROD-2081: Remove PLANNING capability (#1547) #1599

wants to merge 1 commit into from

Conversation

mbiarnes
Copy link
Contributor

@mbiarnes mbiarnes commented Jul 5, 2023

(cherry picked from commit 2e11eb4)

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

BXMSPROD-2081

** kiegroup/kie-wb-distributions#1230
** #1599
** kiegroup/droolsjbpm-integration#2977
** kiegroup/kie-wb-common#3814
** kiegroup/droolsjbpm-build-bootstrap#2344

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@mbiarnes
Copy link
Contributor Author

mbiarnes commented Jul 5, 2023

Jenkins retest this

@mbiarnes mbiarnes marked this pull request as ready for review July 6, 2023 11:11
@mbiarnes mbiarnes changed the title BAPL-2291 Remove PLANNING capability (#1547) BXMSPROD-2081 Remove PLANNING capability (#1547) Jul 6, 2023
@mbiarnes mbiarnes changed the title BXMSPROD-2081 Remove PLANNING capability (#1547) BXMSPROD-2081: Remove PLANNING capability (#1547) Jul 6, 2023
@mbiarnes mbiarnes requested a review from yurloc July 7, 2023 09:18
@lampajr
Copy link
Member

lampajr commented Jul 7, 2023

There is an issue on gha:

2023-07-06T14:45:28.6571236Z /home/runner/work/jbpm-wb/jbpm-wb/kiegroup_jbpm-work-items/jbpm-workitem-itests/src/test/java/org/jbpm/workitem/springboot/samples/KafkaSampleTest.java:[37,33] cannot access io.strimzi.test.container.StrimziKafkaContainer
2023-07-06T14:45:28.6592299Z   bad class file: /home/runner/.m2/repository/io/strimzi/strimzi-test-container/0.104.0/strimzi-test-container-0.104.0.jar(io/strimzi/test/container/StrimziKafkaContainer.class)
2023-07-06T14:45:28.6592854Z     class file has wrong version 55.0, should be 52.0
2023-07-06T14:45:28.6593425Z     Please remove or make sure it appears in the correct subdirectory of the classpath.
2023-07-06T14:45:28.6594017Z 
2023-07-06T14:45:28.6594503Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
2023-07-06T14:45:28.6616400Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
2023-07-06T14:45:28.6617125Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)

@Ginxo seems related to kiegroup/droolsjbpm-build-bootstrap#2334
weird thing is that only gha is failing, jenkins checks are fine.

Therefore I do not think the issue is related to this change

@lampajr lampajr self-requested a review July 7, 2023 09:31
@Ginxo
Copy link
Contributor

Ginxo commented Jul 7, 2023

so It seems java8 is not compatible, right?

@lampajr
Copy link
Member

lampajr commented Jul 7, 2023

so It seems java8 is not compatible, right?

it seems so, on java 11 check there is a different issue so yeah I think it could be the reason

@mbiarnes mbiarnes marked this pull request as draft July 10, 2023 10:54
@Ginxo
Copy link
Contributor

Ginxo commented Jul 11, 2023

@mbiarnes
Copy link
Contributor Author

kiegroup/droolsjbpm-build-bootstrap#2347 and subset of PRs take a fixed version for OptaPlanner

@mbiarnes mbiarnes closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants