Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] Upgrading Apache Velocity to 2.3 #2473

Merged

Conversation

LightGuard
Copy link
Member

@LightGuard LightGuard commented Jul 22, 2024

Full GAV change:
org.apache.velocity:velocity:1.7 ->
org.apache.velocity:velocity-engine-core:2.3

Referenced PRs:

NOTE: There are some changes that need to be made to the velocity configuration. These can be found at https://velocity.apache.org/engine/2.3/upgrading.html#upgrading-from-velocity-22-to-velocity-23. Read all changes until 1.7 to 2.0.
They all apply to this upgrade.
Test and verify any usage of Apache Velocity templates.

Full GAV change:
org.apache.velocity:velocity:1.7 ->
org.apache.velocity:velocity-engine-core:2.3

NOTE: There are some changes that need to be made to the velocity configuration.
These can be found at https://velocity.apache.org/engine/2.3/upgrading.html#upgrading-from-velocity-22-to-velocity-23.
Read all changes until 1.7 to 2.0.
They all apply to this upgrade.
Test and verify any usage of Apache Velocity templates.

Signed-off-by: Jason Porter <lightguard.jp@gmail.com>
@yesamer
Copy link
Member

yesamer commented Jul 23, 2024

jenkins do fdb

1 similar comment
@yesamer
Copy link
Member

yesamer commented Jul 23, 2024

jenkins do fdb

@mareknovotny
Copy link
Member

again @LightGuard use in the PR summary branch name, please to differentiate the PR in the list

@mareknovotny mareknovotny changed the title Upgrading Apache Velocity to 2.3 [7.67.x-blue] Upgrading Apache Velocity to 2.3 Jul 24, 2024
@yesamer
Copy link
Member

yesamer commented Jul 29, 2024

jenkins do fdb

@mareknovotny
Copy link
Member

if you changed artifactId management where are changed related PRs for repositories downstream ? @LightGuard
For instance here https://github.com/kiegroup/kie-wb-common/blob/7.67.x-blue/kie-wb-common-services/kie-wb-common-data-modeller-core/pom.xml#L87-L91 is used still the old artifact name not the new one from here

See here what i did search quickly by https://github.com/search?q=org%3Akiegroup%20velocity&type=code, there is of cource a lot of unrelated hits, but another ones in https://github.com/kiegroup/jbpm-designer/blob/7.67.x-blue/jbpm-designer-backend/pom.xml#L216-L225

@LightGuard
Copy link
Member Author

Looks like I missed the jbpm-designer-backend. I'll have to a more thorough search.

kiegroup/kie-wb-common#3829 is in the kie-wb-common.

@LightGuard
Copy link
Member Author

jenkins do fdb

1 similar comment
@LightGuard
Copy link
Member Author

jenkins do fdb

@LightGuard
Copy link
Member Author

jenkins do fdb

@LightGuard
Copy link
Member Author

Yay! I got a green build! 🕺🏻

@mareknovotny mareknovotny merged commit ea6dc51 into kiegroup:7.67.x-blue Aug 1, 2024
4 checks passed
@LightGuard
Copy link
Member Author

@yesamer or @mareknovotny Build is green, looks like we're good to merge the various PRs for this.

@yesamer
Copy link
Member

yesamer commented Aug 1, 2024

@LightGuard We already merge them, if I'm not wrong :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants