Update CMakeLists.txt and quick-start.sh: change target #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucagiorgino
changed the title
kkrentz
pushed a commit
to kkrentz/filtering-proxy
that referenced
this pull request
Sep 27, 2023
…lave#19) * Update CMakeLists.txt * Update quick-start.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jctullos that propose a solution in an open issue " #16 ". This fix does not solve completely the open issue.
It fix the following error:
`CMake Error at /keystone/sdk/build64/cmake/macros.cmake:126 (add_custom_target):
The target name "package" is reserved or not valid for certain CMake
features, such as generator expressions, and may result in undefined
behavior.
Call Stack (most recent call first):
CMakeLists.txt:78 (add_keystone_package)
CMake Error at CMakeLists.txt:83 (add_dependencies):
Cannot add target-level dependencies to non-existent target "package".`