Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of an empty container status in confirm_remote_startup #1370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OrenZ1
Copy link

@OrenZ1 OrenZ1 commented Feb 29, 2024

Modified confirm_remote_startup method to make handling of empty container status better, so that if a kernel pod dies while still in startup, the startup process will fail and the user won't have to wait for timeout.

Copy link

welcome bot commented Feb 29, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@OrenZ1
Copy link
Author

OrenZ1 commented Feb 29, 2024

Discussed in #1357

@kevin-bates kevin-bates added bug gateway-provisioners Has application for gateway-provisioners (EG 4.0) labels Mar 4, 2024
@OrenZ1
Copy link
Author

OrenZ1 commented Mar 25, 2024

Hey! Is there any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gateway-provisioners Has application for gateway-provisioners (EG 4.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants