Return an error if the wrong role is requested (fix #15)

jtblin · Dec 5, 2016 · 147fa79 · 147fa79
1 parent 2734a63
commit 147fa79
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/cmd/server.go b/cmd/server.go
@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"encoding/json"
+	"fmt"
 	"net"
 	"net/http"
 	"net/http/httputil"
@@ -97,6 +98,13 @@ func (s *Server) roleHandler(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, err.Error(), http.StatusNotFound)
 		return
 	}
+
+	vars := mux.Vars(r)
+	if role != vars["role"] {
+		http.Error(w, fmt.Sprintf("Invalid role %s", vars["role"]), http.StatusForbidden)
+		return
+	}
+
 	roleARN := s.iam.roleARN(role)
 	credentials, err := s.iam.assumeRole(roleARN, remoteIP)
 	if err != nil {