Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rpm.rst: Fix links to the rpm documentation page #2054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

white-gecko
Copy link
Contributor

Fix links to the rpm documentation page

Fix links to the rpm documentation page
Copy link
Owner

@jordansissel jordansissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the docs! I added a note about how this particular documentation file is generated and where the change needs to be made instead.

@@ -35,7 +35,7 @@
* ``--rpm-init FILEPATH``
- Add FILEPATH as an init script
* ``--[no-]rpm-macro-expansion``
- install-time macro expansion in %pre %post %preun %postun scripts (see: https://rpm.org/user_doc/scriptlet_expansion.html)
- install-time macro expansion in %pre %post %preun %postun scripts (see: https://rpm-software-management.github.io/rpm/manual/scriptlet_expansion.html)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated from lib/fpm/package/rpm.rb which has code to declare flags and help text per flag, so these changes need to be made to that file otherwise they'll be lost the next time the docs are generated.

Example:

fpm/lib/fpm/package/rpm.rb

Lines 157 to 159 in d81a1ad

option "--macro-expansion", :flag,
"install-time macro expansion in %pre %post %preun %postun scripts " \
"(see: https://rpm.org/user_doc/scriptlet_expansion.html)", :default => false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants