Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/DB Refresh: refresh & database integrity #501

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hugwuoke
Copy link
Collaborator

@hugwuoke hugwuoke commented Aug 4, 2023

This is what I'm currently thinking, it basically follows my understanding of the the issue #484,

It is missing

  1. Checking in with the frontend
  2. Having the ddl tables because I wasn't sure what they were
  3. I was unsure if using the output from fetch_cset_and_members was the best way of comparing because from my understanding fetch_cset_and_members gets it's information from the api and not through the database as it doesn't use SQL.

@hugwuoke hugwuoke linked an issue Aug 4, 2023 that may be closed by this pull request
@hugwuoke hugwuoke requested a review from Sigfried August 4, 2023 19:20
@@ -0,0 +1,372 @@
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugwuoke I'm going to review and merge this some time soon. If I merge it before you pick up on it again, we can continue any work needed in a new PR.

Only thing I noticed here at a glance is that test_database_integrity needs the file extension .py at the end!

@joeflack4 joeflack4 force-pushed the develop branch 2 times, most recently from deb6201 to 82c3ce8 Compare February 14, 2024 22:09
@joeflack4 joeflack4 force-pushed the develop branch 2 times, most recently from d74edbe to 155fef2 Compare April 26, 2024 21:01
@joeflack4 joeflack4 self-assigned this May 12, 2024
@joeflack4 joeflack4 changed the title Pull request: 484 unit test for database integrity Test/DB Refresh: refresh & database integrity May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 3. Backlog
Development

Successfully merging this pull request may close these issues.

Test/DB Refresh: refresh & database integrity
2 participants