Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a broken URL #250

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Fixed a broken URL #250

merged 1 commit into from
Oct 9, 2020

Conversation

dharmaturtle
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@dharmaturtle
Copy link
Contributor Author

Also, the link to Equinox.CosmosStore's nuget package is broken. Should I point it to Equinox.Cosmos for now until te nuget package gets updated?

image

@bartelink
Copy link
Collaborator

Thanks for spotting (and taking the time to fix!) this.

Regarding the CosmosStore vs Cosmos naming, this is referenced in #232 and #197

Short answer: Yes, use the .Cosmos package (the docs on the v2 branch are in sync with that naming)


Longer answer:

Atm, master has a CosmosStore using the Microsoft.Azure.Cosmos aka v3 package under the hood, and v2 has a .Cosmos which uses Microsoft.Azure.DocumentDb.Client.Core aka v2. There is an alpha of a CosmosStore package on nuget, but thats from the pull request branch above (it uses Azure.Cosmos preview nuget aka v4).

Either way, that .CosmosStore package has some breaking changes (better naming, as well as significant efficiency gains), and the intention is to provide a reasonable upgrade path.

It's likely that, at the point that the CosmosStore package enters rc, that I'll re-add the .Cosmos package source (copied from whatever is on the v2 branch) onto the master branch and each release will include both nugets (without breaking changes to the .Cosmos one). This will allow people to use them side-by-side during the course of switching larger codebases over aggregate-by-aggregate.

We'll hopefully get the README in sync when that happens!

@bartelink bartelink merged commit 244b0f8 into jet:master Oct 9, 2020
bartelink added a commit that referenced this pull request Oct 9, 2020
bartelink added a commit that referenced this pull request Oct 9, 2020
bartelink added a commit that referenced this pull request Oct 9, 2020
bartelink added a commit that referenced this pull request Oct 9, 2020
@bartelink
Copy link
Collaborator

Aside: If this is for local experimentation, then replacing:

<!-- <PackageReference Include="Equinox.Cosmos" Version="2.3.0-rc1" />-->

with

<ProjectReference Include="..\..\..\equinox\src\Equinox.CosmosStore\Equinox.CosmosStore.fsproj" />

can be used to do local experiments

(Alternately if you add a reference to CosmosStore.fs into your project you can simply inline it - one of the key motivations for having most projects contain everything in a single file is to allow people to work around bugs by inlining parts locally)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants