Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user list settings: disable save button on modal on click, re-enable if error happens #875

Merged
merged 1 commit into from
Oct 17, 2023
Merged

user list settings: disable save button on modal on click, re-enable if error happens #875

merged 1 commit into from
Oct 17, 2023

Conversation

iisa
Copy link
Contributor

@iisa iisa commented Oct 11, 2023

No description provided.

@iisa iisa enabled auto-merge (squash) October 11, 2023 01:12
bfalling
bfalling reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question; otherwise, LGTM.

@iisa
Copy link
Contributor Author

iisa commented Oct 13, 2023

closing to use #877

@iisa iisa closed this Oct 13, 2023
auto-merge was automatically disabled October 13, 2023 16:25

Pull request was closed

@iisa iisa reopened this Oct 13, 2023
@iisa iisa merged commit 339e2a8 into master Oct 17, 2023
0 of 2 checks passed
@iisa iisa deleted the disable-list-settings-on-submit branch October 17, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfalling bfalling bfalling left review comments

@nsharma123 nsharma123 nsharma123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iisa @bfalling @nsharma123