updated error handeling in Rego validations

Signed-off-by: santoshkal <ksantosh@intelops.dev>

cmd/regoval_dockerfileval.go

@@ -37,7 +37,7 @@ The required input Dockerfile and  Rego policy files can be either be passed thr
 such as those hosted on GitHub (e.g., https://github.com)
 `,
 	Example: `
-# Validate Dockerfil with Rego policies by providing the required args from local file system
+# Validate Dockerfiles with Rego policies by providing the required args from local file system
 
 ./genval regoval dockerfileval --reqinput=input.json \
 --policy=<'path/to/policy.rego file>
@@ -90,8 +90,7 @@ func runDockerfilevalCmd(cmd *cobra.Command, args []string) error {
 
 		err = validate.ValidateDockerfile(string(dockerfilefileContent), defaultRegoPolicies)
 		if err != nil {
-			log.Errorf("Dockerfile validation failed: %s\n", err)
-			return err
+			return fmt.Errorf("Dockerfile validation failed: %s\n", err)
 		}
 	} else {
 		err := validate.ValidateDockerfile(string(dockerfilefileContent), policy)

pkg/validate/printresults.go

@@ -2,13 +2,13 @@ package validate
 
 import (
 	"encoding/json"
-	"errors"
 	"fmt"
 	"os"
 
 	"github.com/fatih/color"
 	"github.com/jedib0t/go-pretty/v6/table"
 	"github.com/open-policy-agent/opa/rego"
+	"github.com/sirupsen/logrus"
 )
 
 // PrintResults prints the evaluation results along with the metadata
@@ -18,7 +18,6 @@ func PrintResults(result rego.ResultSet, metas []*regoMetadata) error {
 	t.SetOutputMirror(os.Stdout)
 	t.AppendHeader(table.Row{"Policy Name", "Status", "Description", "Severity", "Benchmark", "Category"})
 
-	var policyError error
 	var allResults []Results
 	var idCounter int
 
@@ -43,7 +42,7 @@ func PrintResults(result rego.ResultSet, metas []*regoMetadata) error {
 						} else {
 							saveStatus = "failed"
 							status = color.New(color.FgRed).Sprint("failed")
-							policyError = errors.New("policy evaluation failed: " + key)
+							logrus.Infof("\n" + color.New(color.FgRed).Sprintf("policy evaluation for %s failed", key))
 						}
 					} else {
 						// Handle other types of values (non-slice)
@@ -53,7 +52,7 @@ func PrintResults(result rego.ResultSet, metas []*regoMetadata) error {
 						} else {
 							saveStatus = "failed"
 							status = color.New(color.FgRed).Sprint("failed")
-							policyError = errors.New("policy evaluation failed: " + key)
+							logrus.Infof("\n" + color.New(color.FgRed).Sprintf("policy evaluation for %s failed", key))
 						}
 					}
 					t.AppendRow([]interface{}{key, status, meta.Description, meta.Severity, meta.Benchmark, meta.Category})
@@ -72,11 +71,10 @@ func PrintResults(result rego.ResultSet, metas []*regoMetadata) error {
 			}
 		} else {
 			fmt.Println("No policies passed")
-			policyError = errors.New("no policies passed")
+			logrus.Infof("\n" + color.New(color.FgRed).Sprintf("no policies passed"))
 		}
 	}
 
-	fmt.Println("Rendering table")
 	// Render the table after processing all results
 	t.Render()
 
@@ -87,7 +85,7 @@ func PrintResults(result rego.ResultSet, metas []*regoMetadata) error {
 		}
 	}
 
-	return policyError
+	return nil
 }
 
 type Results struct {