Remove runtime dependency on tableauhyperapi #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Sep 20, 2024
| assert set(result.keys()) == set((table_name, TableName("public", "table2"))) | ||
| assert set(result.keys()) == set( | ||
| ( | ||
| ".".join(table_name._unescaped_components), |
There was a problem hiding this comment.
Note to future self during review - is this OK to do? I think this will technically break users that want a roundtrip of the TableName, which overloads equality semantics.
How important that is...I don't know.
Open
WillAyd
commented
Sep 20, 2024
| "pandas>=2.0.0", | ||
| "polars~=1.2.0", | ||
| "narwhals", | ||
| "tableauhyperapi", |
There was a problem hiding this comment.
Might also want to come up with a way to monkeypatch the tableau installation not existing, and making sure the pantab runtime works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #267