fix goosex migration pgx not imported / update to crdbpgxv5 and pgx/v5 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemrm
requested review from
a team,
nicolerenee and
sfunkhouser
as code owners
Signed-off-by: Mike Mason <mimason@equinix.com>
…driver Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
nicolerenee
approved these changes
Apr 4, 2024
nicolerenee
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pgx/v4 not being imported and upgrades to pgx/v5.
Additionally, tests have been added to ensure migrations should always work in the future.
Finally, this also fixes issue #154 with a panic happening when goosex which results in the logger being called but the logger not previously being set and therefore is nil. Logger is now the Nop logger by default to ensure no panics occur.